[LV] Fix missing REQUIRES: asserts in test #151737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Ramkumar Ramachandra (artagnon) Changese7200c7 ([LV] Pre-commit test for #151664) forgot to require asserts in the test, and stripped a CHECK line in error. Fix this. Full diff: https://github.com/llvm/llvm-project/pull/151737.diff 1 Files Affected:
diff --git a/llvm/test/Transforms/LoopVectorize/AArch64/pr151664-cost-hoisted-vector-scalable.ll b/llvm/test/Transforms/LoopVectorize/AArch64/pr151664-cost-hoisted-vector-scalable.ll
index bdff766110238..bbdf0500588e8 100644
--- a/llvm/test/Transforms/LoopVectorize/AArch64/pr151664-cost-hoisted-vector-scalable.ll
+++ b/llvm/test/Transforms/LoopVectorize/AArch64/pr151664-cost-hoisted-vector-scalable.ll
@@ -1,4 +1,5 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals none --filter-out-after "^scalar.ph" --version 5
+; REQUIRES: asserts
; RUN: opt -passes=loop-vectorize -mtriple=aarch64 -mattr=+sve -S \
; RUN: -debug-only=loop-vectorize %s 2>&1 | FileCheck %s
@@ -7,6 +8,7 @@
; and hence should not be produced by LoopVectorize. Unfortunately, what is
; actually costed is `<4 x float> @llvm.minimumnum`.
+; CHECK: LV: Found an estimated cost of Invalid for VF vscale x 4 For instruction: %res = tail call float @llvm.minimumnum.f32(float %arg, float 0.000000e+00)
define void @cost_hoisted_vector_code(ptr %p, float %arg) {
; CHECK-LABEL: define void @cost_hoisted_vector_code(
; CHECK-SAME: ptr [[P:%.*]], float [[ARG:%.*]]) #[[ATTR0:[0-9]+]] {
|
e7200c7 ([LV] Pre-commit test for llvm#151664) forgot to require asserts in the test, and stripped a CHECK line in error. Fix this.
artagnon
force-pushed
the
lv-151664-test-requires-asserts
branch
from
9b59f17 to
696f408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e7200c7 ([LV] Pre-commit test for #151664) forgot to require asserts in the test, and stripped a CHECK line in error. Fix this.